On Thu, May 09, 2024 at 11:31:06AM +0800, Li Zhijian via wrote: > Make the code more tight. > > Cc: Michael Tokarev <[email protected]> > Signed-off-by: Li Zhijian <[email protected]>
Reviewed-by: Peter Xu <[email protected]> > --- > This change/comment suggested by "Michael Tokarev <[email protected]>" came > a bit late at that time, let's update it together in these minor set > this time. You can use a tag next time: Suggested-by: Michael Tokarev <[email protected]> > --- > migration/colo.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/migration/colo.c b/migration/colo.c > index 991806c06a..1b6d9da1c8 100644 > --- a/migration/colo.c > +++ b/migration/colo.c > @@ -838,12 +838,11 @@ static void *colo_process_incoming_thread(void *opaque) > /* Make sure all file formats throw away their mutable metadata */ > bql_lock(); > bdrv_activate_all(&local_err); > + bql_unlock(); > if (local_err) { > - bql_unlock(); > error_report_err(local_err); > return NULL; > } > - bql_unlock(); > > failover_init_state(); > > -- > 2.31.1 > > -- Peter Xu
