On 23.03.21 14:31, Julien Pivotto wrote: > > I find what we do with Java quite nice: > > https://github.com/prometheus/client_java
Could you be more specific what you are referring to? > Unfortunately for golang, it will be more difficult for at least 2 > releases, the time for go mod lazy loading to come and make its youth > sicknesses. let's not forget client_golang is one of the most used > go libraries out there. Is this meant as a concern that adding more collectors will blow up the number of Go modules involved? In case of the proposed collector for the database/sql, there won't be any new dependencies, so that wouldn't be a concern. Or am I reading you wrong here? In any case, I get the following from the responses so far: - Yes, it would be fine to have more collectors for more or less standardized things in client_golang. We do have something similar in client_java already. - We could put those into a `collectors` package or similar. I actually wanted to do that for the existing collectors, but I couldn't move most of them with the current package layout as that would create circular dependencies. So we could also put them into the normal `client_golang/prometheus` package, given that we have already four other `New...Collector` constructors. Please discuss! (o: - For the SQL collector specifically, whoever implements it should look through the three known implementations so far (and perhaps find out if there are even more) and distill the best design and feature set out of them. (Note that we might also just want to add a collector for core features and point power users to a more specific implementation, cf. how `NewBuildInfoCollector` points to https://github.com/povilasv/prommod .) -- Björn Rabenstein [PGP-ID] 0x851C3DA17D748D03 [email] [email protected] -- You received this message because you are subscribed to the Google Groups "Prometheus Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/prometheus-developers/20210323194554.GV2773%40jahnn.
