I like the idea of making client_golang have more "APM" like features. I'm not sure this would be something to enable by default, but having a central place for these things makes sense to me.
On Tue, Mar 23, 2021 at 11:24 AM Matthias Rampke <[email protected]> wrote: > Ah, even before following the link I had the same questions as Björn: > Could this be a separate thing? Does it benefit significantly from being > part of the standard client_golang, or could it just as well be something > people pull in on demand? > > I see at least two <https://github.com/krpn/go-sql-db-stats> libraries > <https://github.com/dlmiddlecote/sqlstats> that already do this, do we > need a third? What is different about your approach? > > /MR > > On Mon, Mar 22, 2021 at 11:06 AM Mitsuo Heijo <[email protected]> > wrote: > >> Hi Prometheus Developers. >> >> I was guided here from >> https://github.com/prometheus/client_golang/pull/848 >> >> There are several agenda items. >> >> 1. Whether client_golang should include DBStatsCollector. >> 2. Should the metrics be prefixed with go_... ? While the database/sql >> package is Go-specific, those metrics aren't really coming from the Go >> runtime. >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Prometheus Developers" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/prometheus-developers/ecb8b635-8e88-4cd2-880a-c1f00a76d41an%40googlegroups.com >> <https://groups.google.com/d/msgid/prometheus-developers/ecb8b635-8e88-4cd2-880a-c1f00a76d41an%40googlegroups.com?utm_medium=email&utm_source=footer> >> . >> > -- > You received this message because you are subscribed to the Google Groups > "Prometheus Developers" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/prometheus-developers/CAMV%3D_gbvhRNuKHBJC%2BqRMeT-vWZUsfYoUj%2BM_xdPDN%3Dcoob-%3DA%40mail.gmail.com > <https://groups.google.com/d/msgid/prometheus-developers/CAMV%3D_gbvhRNuKHBJC%2BqRMeT-vWZUsfYoUj%2BM_xdPDN%3Dcoob-%3DA%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "Prometheus Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/prometheus-developers/CABbyFmot-EQziwcepriON4ATxQaY5nHR7vboq%3DYZtX780oi8pw%40mail.gmail.com.
