On Sun, Sep 27, 2020 at 03:41:50PM -0000, Dimitri Karamazov wrote: > On Sun, September 27, 2020 13:42, Stuart Henderson wrote: > > On 2020/09/27 13:14, Dimitri Karamazov wrote: > > > >>>> > >>>> Take a look at src/lib/check_sym > >>>> > > > > That is a quick check but is not complete because it cannot tell you if > > types of variables have changed (either passed to functions, or in structs) > > or if structs have changed incompatibly. > > > Then, comparing the output of 'nm -g' in case of both old/new library is more > concise, > I suppose. > > > If check_sym says that exported functions have been removed then you > > must bump major, and if they've been added then bump minor, but there are > > other possible reasons. > > > >>>> > >>> > >>> Also check: > >>> https://www.openbsd.org/faq/ports/specialtopics.html#SharedLibs > >>> > >>> > >>> > >>> I would go with: > >>> SHARED_LIBS += cdd 0.1 # 1.1 > >>> SHARED_LIBS += cddgmp 0.1 # 1.1 > >>> > >>> > >>> > >> Thanks for the references, but there wasn't any explanation of the > >> last column held within comments. Does that relate to the upstream > >> version? If it does then it would be # 1.1 and # > >> 0.0 respectively. > >> > > > > Yes it is the library version number used by upstream. Gives a clue in > > some cases if upstream bumps then we _might_ need to. > > > In that case, the diff below is more accurate.
if it helps, upstream follows the GNU libtool versioning guidelines, in https://www.gnu.org/software/libtool/manual/html_node/Libtool-versioning.html - at least it tries. I think it missed a version bump before (in the version 0.94k, which OpenBSD skipped), but not this time. Dima
