On 2020/09/27 13:14, Dimitri Karamazov wrote: > >>>> > >>>> > >>> How do you find that out? I guess the numbering is independent > >>> of actual upstream numbers, but I'll keep it on the lower side. > >> > >> Take a look at src/lib/check_sym
That is a quick check but is not complete because it cannot tell you if types of variables have changed (either passed to functions, or in structs) or if structs have changed incompatibly. If check_sym says that exported functions have been removed then you must bump major, and if they've been added then bump minor, but there are other possible reasons. > >> > > > > Also check: > > https://www.openbsd.org/faq/ports/specialtopics.html#SharedLibs > > > > > > I would go with: > > SHARED_LIBS += cdd 0.1 # 1.1 > > SHARED_LIBS += cddgmp 0.1 # 1.1 > > > > > Thanks for the references, but there wasn't any explanation of the > last column held within comments. Does that relate to the upstream > version? If it does then it would be # 1.1 and # 0.0 respectively. Yes it is the library version number used by upstream. Gives a clue in some cases if upstream bumps then we _might_ need to. > > Index: Makefile > =================================================================== > RCS file: /cvs/ports/math/cddlib/Makefile,v > retrieving revision 1.1.1.1 > diff -u -p -r1.1.1.1 Makefile > --- Makefile 16 Jul 2020 04:46:18 -0000 1.1.1.1 > +++ Makefile 27 Sep 2020 13:03:26 -0000 > @@ -4,10 +4,10 @@ COMMENT = C library for double descripti > > GH_ACCOUNT = cddlib > GH_PROJECT = cddlib > -GH_TAGNAME = 0.94j > +GH_TAGNAME = 0.94l > > -SHARED_LIBS += cdd 0.0 # 0.0 > -SHARED_LIBS += cddgmp 0.0 # 0.0 > +SHARED_LIBS += cdd 0.1 # 1.1 > +SHARED_LIBS += cddgmp 0.1 # 1.1 > > CATEGORIES = math > > @@ -20,7 +20,6 @@ PERMIT_PACKAGE = Yes > > WANTLIB += c gmp > > -BUILD_DEPENDS = print/texlive/base > LIB_DEPENDS = devel/gmp > > USE_GMAKE = Yes > Index: distinfo > =================================================================== > RCS file: /cvs/ports/math/cddlib/distinfo,v > retrieving revision 1.1.1.1 > diff -u -p -r1.1.1.1 distinfo > --- distinfo 16 Jul 2020 04:46:18 -0000 1.1.1.1 > +++ distinfo 27 Sep 2020 13:03:26 -0000 > @@ -1,2 +1,2 @@ > -SHA256 (cddlib-0.94j.tar.gz) = 9Uu6eFufaBS+XPbXaGHdYQgpl8e0jgJE/DzOpxlYktQ= > -SIZE (cddlib-0.94j.tar.gz) = 496651 > +SHA256 (cddlib-0.94l.tar.gz) = 0TyOj7Pm6P/9A0bgo5b833zq4oyjxPe//68Pr4Novb0= > +SIZE (cddlib-0.94l.tar.gz) = 493895 > Index: patches/patch-Makefile_am > =================================================================== > RCS file: patches/patch-Makefile_am > diff -N patches/patch-Makefile_am > --- /dev/null 1 Jan 1970 00:00:00 -0000 > +++ patches/patch-Makefile_am 27 Sep 2020 13:03:26 -0000 > @@ -0,0 +1,13 @@ > +$OpenBSD$ > + > +Avoid building documentation > + > +--- Makefile.am.orig Sun Sep 20 20:38:23 2020 > ++++ Makefile.am Sun Sep 20 20:38:36 2020 > +@@ -1,5 +1,5 @@ > + # Directories where we can build something. > +-SUBDIRS = doc lib-src src > ++SUBDIRS = lib-src src > + > + # Install the examples into /usr/share/doc/cddlib/examples* > + nobase_doc_DATA = $(srcdir)/examples/* $(srcdir)/examples-ine/* > $(srcdir)/examples-ine3d/* $(srcdir)/examples-ext/* > Index: pkg/PLIST > =================================================================== > RCS file: /cvs/ports/math/cddlib/pkg/PLIST,v > retrieving revision 1.1.1.1 > diff -u -p -r1.1.1.1 PLIST > --- pkg/PLIST 16 Jul 2020 04:46:18 -0000 1.1.1.1 > +++ pkg/PLIST 27 Sep 2020 13:03:26 -0000 > @@ -1,4 +1,4 @@ > -@comment $OpenBSD: PLIST,v 1.1.1.1 2020/07/16 04:46:18 daniel Exp $ > +@comment $OpenBSD: PLIST,v$ > @bin bin/adjacency > @bin bin/adjacency_gmp > @bin bin/allfaces > @@ -27,24 +27,23 @@ > @bin bin/testlp3_gmp > @bin bin/testshoot > @bin bin/testshoot_gmp > -include/cdd.h > -include/cdd_f.h > -include/cddmp.h > -include/cddmp_f.h > -include/cddtypes.h > -include/cddtypes_f.h > -include/setoper.h > -include/splitmix64.h > +include/cddlib/ > +include/cddlib/cdd.h > +include/cddlib/cdd_f.h > +include/cddlib/cddmp.h > +include/cddlib/cddmp_f.h > +include/cddlib/cddtypes.h > +include/cddlib/cddtypes_f.h > +include/cddlib/setoper.h > +include/cddlib/splitmix64.h > @static-lib lib/libcdd.a > lib/libcdd.la > @lib lib/libcdd.so.${LIBcdd_VERSION} > @static-lib lib/libcddgmp.a > lib/libcddgmp.la > @lib lib/libcddgmp.so.${LIBcddgmp_VERSION} > +lib/pkgconfig/cddlib.pc > share/doc/cddlib/ > -share/doc/cddlib/cddlibman.dvi > -share/doc/cddlib/cddlibman.pdf > -share/doc/cddlib/cddlibman.ps > share/doc/cddlib/examples/ > share/doc/cddlib/examples-ext/ > share/doc/cddlib/examples-ext/ccc4.ext > >
