On Sun, Aug 30, 2020 at 09:44:24AM +0100, Laurence Tratt wrote:
> On Wed, Aug 19, 2020 at 03:06:37PM +0100, Laurence Tratt wrote:
> 
> >> Also didn't build for me. Disable/fix mono support?
> > Aha, yes, I can see this too if mono is installed. I've disabled the mono
> > support in appindicator.
> >
> > Updates for libindicator/libappindicator attached (alongside a
> > not-updated-but-here-for-completeness gromit-mpx).
> 
> Has anyone had a chance to look at this yet? Thanks!

libindicator:

 - It has a test suite, but the tests fail. If we can't fix them (can
   we?), then we should add a comment next to NO_TEST.


libappindicator:

 - Running `make plist` changed the plist. Some of this looks like
   churn, but I think it's picked up vala on my system. We should either
   add vala as a dep, or disable vala. Probably the latter?

```
--- pkg/PLIST.orig      Wed Aug 19 12:10:42 2020
+++ pkg/PLIST   Wed Sep  2 17:33:05 2020
@@ -3,16 +3,12 @@
 include/libappindicator3-0.1/libappindicator/
 include/libappindicator3-0.1/libappindicator/app-indicator-enum-types.h
 include/libappindicator3-0.1/libappindicator/app-indicator.h
-lib/girepository-1.0/
 lib/girepository-1.0/AppIndicator3-0.1.typelib
 @static-lib lib/libappindicator3.a
 lib/libappindicator3.la
 @lib lib/libappindicator3.so.${LIBappindicator3_VERSION}
 lib/pkgconfig/appindicator3-0.1.pc
-share/gir-1.0/
 share/gir-1.0/AppIndicator3-0.1.gir
-share/gtk-doc/
-share/gtk-doc/html/
 share/gtk-doc/html/libappindicator/
 share/gtk-doc/html/libappindicator/annotation-glossary.html
 share/gtk-doc/html/libappindicator/api-index-0-5.html
@@ -29,3 +25,5 @@
 share/gtk-doc/html/libappindicator/right.png
 share/gtk-doc/html/libappindicator/style.css
 share/gtk-doc/html/libappindicator/up.png
+share/vala/vapi/appindicator3-0.1.deps
+share/vala/vapi/appindicator3-0.1.vapi
```

 - Ugh, annoying there is no --disable-mono. Patch will have to do.

 - The configure script is checking for python2.7 and pygtk. Should pygtk be a
   dependency of some kind?

 - Looks like PORTHOME isn't needed?

 - Also seems to have a test suite, but would need work to get going.
   Fix or add a comment?

gromit-mpx:

 - Does it need COMPILER?

 - When running it says it can't grab F9. At first I thought that my
   window manager or desktop had it bound, but it doesn't appear so.
   Regardless, managed to turn on scribbling using the tray icon, then
   failed to work out how to turn it off :P pkill to the rescue.
   Probably a problem local to me.

If you can send revised tarballs, I'll chuck this into a mini-bulk to
check for missing dependencies.

Thanks, and sorry for the delay.

-- 
Best Regards
Edd Barrett

http://www.theunixzoo.co.uk

Reply via email to