On Wed, Aug 19, 2020 at 10:59:10AM +0100, Edd Barrett wrote: Hello Edd,
Thanks for your comments!
> libindicator:
>
> ```
> $ make port-lib-depends-check
> libindicator-12.10.1(x11/libindicator):
> Missing: c++.5 (/usr/local/libexec/indicator-loader3) (system lib)
> Missing: c++abi.3 (/usr/local/libexec/indicator-loader3) (system lib)
> WANTLIB += ${COMPILER_LIBCXX}
> ```
Fixed for both libindicator and libappindicator.
> Some of the paths in the PLIST include what appears to be some kind of version
> number (although not that of libindicator). E.g.:
> include/libindicator3-0.4/*
> lib/pkgconfig/indicator3-0.4.pc
>
> It might be OK for the headers to include the version, as pkg-config could
> provide the right path, but isn't it kind of annoying for consumers to have to
> provide that exact version string when asking pkg-config for the flags?
AFAIK libappindicator is the only consumer of libindicator, so the fact that
it searches for a specific version suggests to me that things are best left
as-is (even though it does feel a bit weird). It'll certainly make updates
less painful in the future.
> Also didn't build for me. Disable/fix mono support?
Aha, yes, I can see this too if mono is installed. I've disabled the mono
support in appindicator.
Updates for libindicator/libappindicator attached (alongside a
not-updated-but-here-for-completeness gromit-mpx).
Laurie
libindicator.tgz
Description: application/tar-gz
libappindicator.tgz
Description: application/tar-gz
gromit-mpx.tgz
Description: application/tar-gz
