On Sat, July 11, 2020 12:58 pm, octeep wrote: > > On 2020-07-11 20:41, Dimitri Karamazov wrote: > >> 3. In my opinion all the version info you've added is pedantic? correct >> me if I'm wrong. > > I saw other ports are using QT5_VERSION and QT5_NEXT_VERSION > > > to specify the Qt version so I thought this was the common standard. > > Spectral specified that the Qt version had to be 5.12 > I should've posed it as question instead of a snarky comment. I don't understand the significance of it here in your port, you can mostly find in x11/qt5 directory and not anywhere else in qt5 ports Also the Qt in OpenBSD is 5.13 so there's no need to specify it in my opinion.
>> 4. Also the fetch fails. Do `make clean=dist` and check again. >> May be use GH_* variables defined in bsd.port.mk instead of MASTER_SITE >> > > Sorry, but I am not sure how to define GH_* when the sources have to be > > > fetched from 2 repos. So I used MASTER_SITE instead. > > `make fetch` works fine on my machine, do you mind sending me the error > logs? > Hey, nevermind it was probably a network error on my part, some sort of 'couldn't sign in/up' from ftp which I'd never seen before. The port looks cool though has an material design android'ish feel. I build and run-tested it briefly.
