On 2020-07-11 20:41, Dimitri Karamazov wrote:
> Hey, here are my my two cents
> 1. Keep each argument to MODULES, DISTFILES, {RUN,BUILD,LIB}_DEPENDS, and
>     also the post-extract in post-extract on a separate line & atmost 80
>     chars.
> 2. Keep a tab-space btw the operator and the argument. And all arguments
>     should line up.

> 5. Run '/usr/ports/infrastructure/bin/portcheck' at the end and clear rest of
>     the formatting errors.

Fixed this, here is the new port.


> 3. In my opinion all the version info you've added is pedantic? correct me
>     if I'm wrong.

I saw other ports are using QT5_VERSION and QT5_NEXT_VERSION

to specify the Qt version so I thought this was the common standard.

Spectral specified that the Qt version had to be 5.12 or above.


> 4. Also the fetch fails. Do `make clean=dist` and check again.
>     May be use GH_* variables defined in bsd.port.mk instead of MASTER_SITE

Sorry, but I am not sure how to define GH_* when the sources have to be

fetched from 2 repos. So I used MASTER_SITE instead.

`make fetch` works fine on my machine, do you mind sending me the error 
logs?



Attachment: spectral.tar.gz
Description: application/gzip

Reply via email to