On 2020/05/30 01:30, Alex Free wrote: > > Sent: Saturday, May 30, 2020 at 12:35 AM > > From: "Stuart Henderson" <s...@spacehopper.org> > > To: "Alex Free" <ale...@mail.com> > > Cc: ports@openbsd.org > > Subject: Re: what is the proper procedure for submitting changes to > > existing ports? > > > > On 2020/05/30 00:23, Alex Free wrote: > > > What is the proper procedure for sending changes and patches to existing > > > ports? I have modified 3 ports and would like my changes to be commuted. > > > My modifications are to: > > > > > > games/ioquake3 (adds PowerPC support for OpenBSD. IOQuake3 does > > > currently support any PowerPC *BSD OS, I had to add support myself. > > > x11/mplayer (adds an altivec flavor, crucial for good video playback) > > > graphics/ffmpeg (adds an altivec flavor for increased performance and > > > more) > > > > > > I have submitted patches for FFmpeg and IOQuake3 to this mailing list. I > > > have also sent patches for Mplayer, FFmpeg, and IOQuake3 directly to > > > the maintainers. Is this the proper way? > > > > > > > Either mail to maintainer, or to list + maintainer, is good. > > Please send unified diffs (preferably cvs diff -u or git diff > > against either the main repository or the conversion on > > github.com/openbsd). > > > > Re the altivec one, if it works, using ports-gcc would be better > > than hardcoding CC=gcc to use the old base compiler that hasn't > > been removed yet but afaik nothing should be using. > > > > > > Are these diffs in the links below in proper format? Thanks for the help > as I’ve > never done this before.
No - please send "cvs diff -u" or "git diff" depending on where you got your ports tree from. > The AltiVec patches are crucial to playing 360p > x264 MP4 files on my 1.42GHz G4, as well as speeding up file conversion. > The IOQuake3 patches are the first to support any PowerPC BSD, and were > pretty straight forward to figure out. > > https://marc.info/?l=openbsd-ports&m=159072101614301&w=2 > > https://marc.info/?l=openbsd-ports&m=159071707413348&w=2 The altivec patch forces CC=gcc which is the old base-system gcc which generally shouldn't be used any more. Since there is a problem with clang then you can try setting COMPILER=ports-gcc to use a more modern version of gcc from ports.
