On Tue May 19, 2020 at 11:31:07AM +0200, Landry Breuil wrote:
> On Mon, May 18, 2020 at 07:07:27AM +0200, Rafael Sadowski wrote:
> CONFIGURE_ARGS+= always scares me, what if something else down the chain
> does CONFIGURE_ARGS= and drops all the other bits ?

tldr: Don't worry, port-modules(5) do the magic for us.

For example: devel/catch2

$ make show=CONFIGURE_ARGS
-DPYTHON_EXECUTABLE=/usr/local/bin/python3.7
-DPYTHON_LIBRARY_DIRS=/usr/local/lib/python3.7
-DPYTHON_INCLUDE_DIR=/usr/local/include/python3.7m -DCMAKE_BUILD_TYPE=Release

If I add "CONFIGURE_ARGS = -DTEST=WTF" or "CONFIGURE_ARGS += -DTEST=WTF", we'll 
see:

$ make show=CONFIGURE_ARGS
-DTEST=WTF -DPYTHON_EXECUTABLE=/usr/local/bin/python3.7
-DPYTHON_LIBRARY_DIRS=/usr/local/lib/python3.7
-DPYTHON_INCLUDE_DIR=/usr/local/include/python3.7m -DCMAKE_BUILD_TYPE=Release

... even if we add "CONFIGURE_ARGS =" (empty), we'll see:

$ make show=CONFIGURE_ARGS
-DPYTHON_EXECUTABLE=/usr/local/bin/python3.7
-DPYTHON_LIBRARY_DIRS=/usr/local/lib/python3.7
-DPYTHON_INCLUDE_DIR=/usr/local/include/python3.7m -DCMAKE_BUILD_TYPE=Release

Rafael

Reply via email to