On Mon, May 18, 2020 at 07:07:27AM +0200, Rafael Sadowski wrote: > This diff currently runs through a full amd64 bulk build. I send this > diff in advance to discuss it. Here a list of imported port changes: > > - Update CMmke to 3.17.2 > > - Switch CMake to pyhton3
Makes 100% sense > - Remove all Modules under files. This should no longer be necessary. I like that idea, provided that doesnt cause subtle build config changes that will result in runtime breakage... where do our modules come from ? taken from upstream at some point, then tweaked for our needs ? were those changes upstreamed and are not needed now, are the upstream modules better now so that we dont need our local ones ? > - Remove our self hacked MODJAVA* MODLUA* MODPY* MODRUBY* modules. > - Instead we help the original cmake modules, see cmake.port.mk. That > saves and all these patches and is in my opinion more correct! >From my understanding of the patch, the idea is to only set some module vars if the corresponding MODULE is enabled, instead of setting the vars in all cases ? are we sure ordering of module inclusion doesnt matter then ? CONFIGURE_ARGS+= always scares me, what if something else down the chain does CONFIGURE_ARGS= and drops all the other bits ? which patches this allows us to remove ? > - Fix cmake debug packages: > - If DEBUG_PACKAGES set don't create install stripa rule. Idea by > landry@ Long-term, i think upstream should be consulted about that. Upstreaming that would be nice, instead of a local patch/hack. That said, patch-Source_cmInstallTargetGenerator_cxx needs a comment :) > What do you think? I would like to commit this diff if the bulk build > is successful. > > Opinions? I'm scared. Now is the right time, but i expect many weird/random build/runtime failures later on, which might not show up in 'just running a bulk' ... Landry
