On Fri, Mar 06, 2020 at 03:26:30PM +0100, Renaud Allard wrote:
> 
> 
> On 3/6/20 2:31 PM, Renaud Allard wrote:
> > 
> > Here is an update to the port with all landry@ and solene@ modifications.
> > 
> 
> Sorry, small mistake in py-treq with py3
> Here it is again

going to import it soonish, but minor nits -

        setup_requires=["incremental"],
        use_incremental=True,
        install_requires=[
            "incremental",
            "requests >= 2.1.0",
            "six",
            "Twisted[tls] >= 16.4.0",
            "attrs",
        ],

i think py-treq needs some additional RDEPs, and i'd locally fix the
added BDEP on incremental to use ${MODPY_FLAVOR} instead of hardcoding
,python3 like you did.

make test fails on:

    import httpbin
E   ModuleNotFoundError: No module named 'httpbin'

so it might also need additional TDEPs :)

Landry

Reply via email to