On Wed, Feb 26, 2020 at 03:20:46PM +0100, Landry Breuil wrote:
> On Wed, Feb 26, 2020 at 02:57:32PM +0100, Renaud Allard wrote:
> > If I attach the tarball, it will be better.
> >
> > On 2/26/20 2:03 PM, Renaud Allard wrote:
> > > Hello,
> > >
> > > Here is a port (python3 only) for matrix synapse server
> > >
> > > Best Regards
>
> assorted nits after a very basic review/test (but they all come from the
> fact that i advised you to remove the flavors and just default to py3
> everywhere):
>
> Fatal: Unknown flavor(s) python3 (in textproc/py-unpaddedbase64)
> (No flavors for this port). (in textproc/py-unpaddedbase64)
> Fatal: Unknown flavor(s) python3 (in textproc/py-signedjson)
> (No flavors for this port). (in textproc/py-signedjson)
> Fatal: Unknown flavor(s) python3 (in textproc/py-canonicaljson)
> (No flavors for this port). (in textproc/py-canonicaljson)
> Fatal: Unknown flavor(s) python3 (in devel/py-importlib-metadata)
> (No flavors for this port). (in devel/py-importlib-metadata)
> Fatal: Unknown flavor(s) python3 (in www/py-macaroons)
> (No flavors for this port). (in www/py-macaroons)
> Fatal: Unknown flavor(s) python3 (in www/py-treq)
> (No flavors for this port). (in www/py-treq)
> Fatal: Unknown flavor(s) python3 (in security/py-libnacl)
> (No flavors for this port). (in security/py-libnacl)
>
> RUN_DEPENDS should be updated to remove ${MODPY_FLAVOR} for new
> dependencies that dont have a FLAVOR:)
>
> py-signedjson also depends on the py3-flavoured version of
> py-canonicaljson/unbpaddedbase64 & libnacl but they're not here.
>
> same thing if you remove a flavor remove the corresponding chunk:
>
> *** Parse error in /home/landry/mystuff/devel/py-importlib-metadata:
> Malformed conditional (! ${FLAVOR:Mpython3}) (Makefile:26)
>
> net/synapse/PLIST should be sorted; ie the var/synapse chunk with the
> @mode/@group should be at the end.. make update-plist to the rescue :)
>
> new ports should start with an empty REVISION
>
> will look deeper tmrw!
py-signedjson both has MODPY_PI & GH_*, there's no 1.1.0 tarball on pypi
===> Checking files for py3-signedjson-1.1.0
>> Fetch
>> https://pypi.io/packages/source/p/python-signedjson/python-signedjson-1.1.0.tar.gz
ftp: Error retrieving
https://files.pythonhosted.org/packages/source/p/python-signedjson/python-signedjson-1.1.0.tar.gz:
404 Not Found
