Thank you for the corrections and comments.
On 1/20/20 5:26 PM, Klemens Nanni wrote:
On Mon, Jan 20, 2020 at 03:17:09PM -0400, Dnsgate wrote:
This is a port update for the CLI file manager sysutils/nnn
This patch updates nnn from 2.8.1 to 2.9
Please send diffs inline, not attached.
Changes and version info here:
https://github.com/jarun/nnn/releases/tag/v2.9
Tested on amd64 for a couple of days and I have found it to be more stable
than the previous versions.
Also the new default key bindings are nicer and work better in tiling window
managers like dwm.
I think users will appreciate this update.
All of this is subjective? What makes it "more stable"? What bindings
change?
Yes, this is from my own experience using the application since v1.8 on
OpenBSD
for example, copying large files (>10GB) produced a core dump or an
application hang randomly.
Also, on reading very large remote directories (NFS) the application
hanged.
This is no longer a problem with 2.9.
Again this is in my experience using -current on bare metal (T450s and a
DELL T1700)
The key bindings where changed for 2.9, more info here:
"Sane keybinds and switches"
https://github.com/jarun/nnn/issues/422
Index: Makefile
===================================================================
RCS file: /cvs/ports/sysutils/nnn/Makefile,v
retrieving revision 1.4
diff -u -p -r1.4 Makefile
--- Makefile 13 Jan 2020 17:53:31 -0000 1.4
+++ Makefile 20 Jan 2020 21:22:46 -0000
@@ -2,7 +2,7 @@
COMMENT = the missing terminal file browser for X
-V = 2.8.1
+V = 2.9
DISTNAME = nnn-v${V}
PKGNAME = nnn-${V}
@@ -21,8 +21,6 @@ MASTER_SITES = https://github.com/jarun
RUN_DEPENDS = shells/bash
-MAKE_FLAGS = CFLAGS_OPTIMIZATION=
-
Why? It now builds with "-O3" again.
Reverted the change.
USE_GMAKE = Yes
NO_TEST = Yes
@@ -30,9 +28,7 @@ WRKDIST = ${WRKDIR}/nnn
do-install:
${INSTALL_PROGRAM} ${WRKSRC}/nnn ${PREFIX}/bin/
- ${INSTALL_PROGRAM} ${WRKSRC}/misc/nlay/nlay ${PREFIX}/bin/
${INSTALL_MAN} ${WRKSRC}/nnn.1 ${PREFIX}/man/man1/
- ${INSTALL_MAN} ${WRKSRC}/misc/nlay/nlay.1 ${PREFIX}/man/man1/
Why?
Also, the PLIST update would be missing, so this is wrong in both ways.
nlay is no longer used by nnn.
See:
https://github.com/jarun/nnn/issues/213
I updated the PLIST and re-tested the build.
${INSTALL_DATA_DIR} ${PREFIX}/share/bash-completion/completions/
${INSTALL_DATA} ${WRKSRC}/misc/auto-completion/bash/nnn-completion.bash
\
Here is the updated diff:
Index: Makefile
===================================================================
RCS file: /cvs/ports/sysutils/nnn/Makefile,v
retrieving revision 1.4
diff -u -p -u -r1.4 Makefile
--- Makefile 13 Jan 2020 17:53:31 -0000 1.4
+++ Makefile 20 Jan 2020 22:00:32 -0000
@@ -2,7 +2,7 @@
COMMENT = the missing terminal file browser for X
-V = 2.8.1
+V = 2.9
DISTNAME = nnn-v${V}
PKGNAME = nnn-${V}
@@ -30,9 +30,7 @@ WRKDIST = ${WRKDIR}/nnn
do-install:
${INSTALL_PROGRAM} ${WRKSRC}/nnn ${PREFIX}/bin/
- ${INSTALL_PROGRAM} ${WRKSRC}/misc/nlay/nlay ${PREFIX}/bin/
${INSTALL_MAN} ${WRKSRC}/nnn.1 ${PREFIX}/man/man1/
- ${INSTALL_MAN} ${WRKSRC}/misc/nlay/nlay.1 ${PREFIX}/man/man1/
${INSTALL_DATA_DIR} ${PREFIX}/share/bash-completion/completions/
${INSTALL_DATA}
${WRKSRC}/misc/auto-completion/bash/nnn-completion.bash \
Index: distinfo
===================================================================
RCS file: /cvs/ports/sysutils/nnn/distinfo,v
retrieving revision 1.2
diff -u -p -u -r1.2 distinfo
--- distinfo 13 Jan 2020 17:53:32 -0000 1.2
+++ distinfo 20 Jan 2020 22:00:32 -0000
@@ -1,2 +1,2 @@
-SHA256 (nnn-v2.8.1.tar.gz) = 4Pr45ifU+GBQ9XyzHu4hvw4hOK3vjtVBKwc12ptdh7w=
-SIZE (nnn-v2.8.1.tar.gz) = 91353
+SHA256 (nnn-v2.9.tar.gz) = ugsHsNh7ptZEIlnal22OM+1pjeQygjr7b8b2gBy92fY=
+SIZE (nnn-v2.9.tar.gz) = 99324
Index: pkg/PLIST
===================================================================
RCS file: /cvs/ports/sysutils/nnn/pkg/PLIST,v
retrieving revision 1.2
diff -u -p -u -r1.2 PLIST
--- pkg/PLIST 13 Jan 2020 17:53:32 -0000 1.2
+++ pkg/PLIST 20 Jan 2020 22:00:32 -0000
@@ -1,7 +1,5 @@
@comment $OpenBSD: PLIST,v 1.2 2020/01/13 17:53:32 bket Exp $
-bin/nlay
@bin bin/nnn
-@man man/man1/nlay.1
@man man/man1/nnn.1
share/bash-completion/
share/bash-completion/completions/
