On Mon, Jan 20, 2020 at 03:17:09PM -0400, Dnsgate wrote:
> This is a port update for the CLI file manager sysutils/nnn
> 
> This patch updates nnn from  2.8.1 to 2.9
Please send diffs inline,  not attached.

> Changes and version info here:
> https://github.com/jarun/nnn/releases/tag/v2.9
> 
> Tested on amd64 for a couple of days and I have found it to be more stable
> than the previous versions.
> Also the new default key bindings are nicer and work better in tiling window
> managers like dwm.
> 
> I think users will appreciate this update.
All of this is subjective?  What makes it "more stable"?  What bindings
change?


>Index: Makefile
>===================================================================
>RCS file: /cvs/ports/sysutils/nnn/Makefile,v
>retrieving revision 1.4
>diff -u -p -r1.4 Makefile
>--- Makefile   13 Jan 2020 17:53:31 -0000      1.4
>+++ Makefile   20 Jan 2020 21:22:46 -0000
>@@ -2,7 +2,7 @@
> 
> COMMENT =             the missing terminal file browser for X
> 
>-V =                   2.8.1
>+V =                   2.9
> DISTNAME =            nnn-v${V}
> PKGNAME =             nnn-${V}
> 
>@@ -21,8 +21,6 @@ MASTER_SITES =               https://github.com/jarun
> 
> RUN_DEPENDS =         shells/bash
> 
>-MAKE_FLAGS =          CFLAGS_OPTIMIZATION=
>-
Why?  It now builds with "-O3" again.

> USE_GMAKE =           Yes
> NO_TEST =             Yes
> 
>@@ -30,9 +28,7 @@ WRKDIST =            ${WRKDIR}/nnn
> 
> do-install:
>       ${INSTALL_PROGRAM} ${WRKSRC}/nnn ${PREFIX}/bin/
>-      ${INSTALL_PROGRAM} ${WRKSRC}/misc/nlay/nlay ${PREFIX}/bin/
>       ${INSTALL_MAN} ${WRKSRC}/nnn.1 ${PREFIX}/man/man1/
>-      ${INSTALL_MAN} ${WRKSRC}/misc/nlay/nlay.1 ${PREFIX}/man/man1/
Why?
Also, the PLIST update would be missing, so this is wrong in both ways.

> 
>       ${INSTALL_DATA_DIR} ${PREFIX}/share/bash-completion/completions/
>       ${INSTALL_DATA} ${WRKSRC}/misc/auto-completion/bash/nnn-completion.bash 
> \

Reply via email to