On 2020/01/10 10:45, Martin Reindl wrote: > Hello ports@ > > This a new port for py-tables, a Python package for managing hierarchical > datasets and designed to efficiently and easily cope with extremely large > amounts of data. > > py-tables 3.6.1 is python3-only. > > Comments? OK? > > -m
Diff below: - for a py3-only port we don't need the annoying -3 suffix on binaries, it is only there to de-conflict when installed alongside py2. - currently we don't use FLAVORs for py3-only ports, so just set MODPY_VERSION=${MODPY_DEFAULT_VERSION_3}. Maybe we want to change that sometime as a conscious decision but for now it's better to be consistent in the tree. - I'm not sure that python's arch strings match up with OpenBSD's ${ARCH} everywhere (thinking mostly about machines where uname -m and uname -p differ), rather than figuring it out we can just use a wildcard in TESTLIBDIR and the shell will expand it where used OK with this diff on top. diff abdd586f72cacb491af994d1ab8caafdba66feae /usr/ports/mystuff blob - e376d36673bd86b5fc51460ded3551ceeb14356b file + math/py-tables/Makefile --- math/py-tables/Makefile +++ math/py-tables/Makefile @@ -1,6 +1,6 @@ # $OpenBSD$ -COMMENT= A Python package to manage extremely large amounts of data +COMMENT= Python package to manage extremely large amounts of data MODPY_EGG_VERSION= 3.6.1 DISTNAME= tables-${MODPY_EGG_VERSION} @@ -22,9 +22,6 @@ MODPY_PYTEST_ARGS= ${TESTLIBDIR} WANTLIB= pthread ${MODPY_WANTLIB} blosc bz2 hdf5 lzo2 -FLAVORS= python3 -FLAVOR?= - MODPY_DISTUTILS_BUILDARGS= --hdf5=${LOCALBASE} \ --lzo=${LOCALBASE} @@ -45,13 +42,8 @@ TEST_DEPENDS= devel/py-coveralls${MODPY_FLAVOR} \ devel/py-test-cov${MODPY_FLAVOR} \ math/py-numexpr${MODPY_FLAVOR} -TESTLIBDIR= ${WRKSRC}/lib.openbsd-${OSREV}-${ARCH}-${MODPY_VERSION}/tables/ +TESTLIBDIR= ${WRKSRC}/lib.openbsd-*/tables/ TEST_ENV= PYTHONPATH=${WRKSRC}/${TESTLIBDIR} - -post-install: - for i in ${PREFIX}/bin/*; do \ - mv $${i} $${i}${MODPY_BIN_SUFFIX} ;\ - done .include <bsd.port.mk> blob - ed7d3ab5d5d547ea5f96cc2fffec060de5d99ae3 file + math/py-tables/pkg/PLIST --- math/py-tables/pkg/PLIST +++ math/py-tables/pkg/PLIST @@ -1,8 +1,8 @@ @comment $OpenBSD: PLIST,v$ -bin/pt2to3${MODPY_BIN_SUFFIX} -bin/ptdump${MODPY_BIN_SUFFIX} -bin/ptrepack${MODPY_BIN_SUFFIX} -bin/pttree${MODPY_BIN_SUFFIX} +bin/pt2to3 +bin/ptdump +bin/ptrepack +bin/pttree lib/python${MODPY_VERSION}/site-packages/tables/ lib/python${MODPY_VERSION}/site-packages/tables-${MODPY_EGG_VERSION}-py${MODPY_VERSION}.egg-info/ lib/python${MODPY_VERSION}/site-packages/tables-${MODPY_EGG_VERSION}-py${MODPY_VERSION}.egg-info/PKG-INFO