Am Tue, 27 Aug 2019 17:56:58 +0100
schrieb Stuart Henderson <[email protected]>:
> Here is your port cleaned up a little. I'll quote a diff and comment
> inline so you can see what I changed.
Thanks.
> what is your intention with the clamav flavour? it's mentioned in
> DESCR but not used in Makefile.
I think this is a leftover from the dansguardian port, which I used as a
"template".
> :: -MAKE_ENV= MKDIR_P='mkdir -p'
>
> i think this is unnecessary?
Not sure, it was used in a similar port which also used ./autogen.sh.
But if this all is handled by autoreconf it should be unnecessary, yes.
> :: -@pkgpath www/e2guardian,clamav
>
> this line is bogus.
Then so it is posśibly in www/dansguardian
> :: -@newgroup _e2guardian:833
> :: -@newuser
> _e2guardian:833:833:daemon:E2Guardian:/nonexistent:/sbin/nologin ::
> +@newgroup _e2guardian:842 :: +@newuser
> _e2guardian:842:842:daemon:e2guardian user:/nonexistent:/sbin/nologin
>
> 833 is taken, the next free is 842
It was the newest on -STABLE, I didn't check -CURRENT, sorry ....
> :: -@mode 0755
> :: @rcscript ${RCDIR}/e2guardian
> :: -@mode
>
> @mode not needed here
Again, same as in www/dansguardian. One can only be so good as one
learns from existing examples :) But again, thank you for your work.
Henry
