Thanks, I appreciate that you found the fix for it! I'm traveling currently and can commit the change only on Sunday.
I'm not sure if this should really be built if there is truly no hardware that's compatible... The alternative would excluding PPC and maybe a few other arches that are known to not work with any compatible hardware. On Mon, Jul 15, 2019, at 3:42 PM, Charlene Wendling wrote: > > > http://build-failures.rhaalovely.net//powerpc/2019-06-29/graphics/vulkan-loader.log > > The problem here is pretty simple as soon as base-gcc is implied: > > - it has missing switches (that's the failure seen in the log) > - anonymous unions require -std=gnu99 (that's also in the log, > "declarations that declare nothing" warnings) > - i fixed those in the CMakeLists, but then it fails with another > classic: "error: thread-local storage not supported for this target" > > I guess it's enough to allow me a COMPILER change. It has fixed the > build [0], i can't say anything about runtime since no macppc > video cards are compatible. > > I made no REVISION bump, because it has never been built on base-gcc > archs and it implies no changes for base-clang ones. > > Comments/feedback are welcome! > > Charlène. > > [0] https://bin.charlenew.xyz/vulkan-loader.log > > > Index: Makefile > =================================================================== > RCS file: /cvs/ports/graphics/vulkan-loader/Makefile,v > retrieving revision 1.3 > diff -u -p -u -p -r1.3 Makefile > --- Makefile 22 Jun 2019 17:02:24 -0000 1.3 > +++ Makefile 15 Jul 2019 21:25:27 -0000 > @@ -26,6 +26,9 @@ RUN_DEPENDS = graphics/vulkan-headers > > CONFIGURE_ARGS = -DBUILD_WSI_WAYLAND_SUPPORT=False > > +# Thread local storage > +COMPILER = base-clang ports-gcc > + > MODULES = devel/cmake \ > lang/python > MODPY_VERSION = ${MODPY_DEFAULT_VERSION_3} > -- tfrohw...@fastmail.com PGP Public Key: https://pgp.mit.edu/pks/lookup?op=get&search=0xE1A22D58D20C6D22
