On Fri, Apr 26, 2019 at 12:50:54AM -0400, Kurt Mosiejczuk wrote: > > It's generally good practice to make your port on -current. It doesn't > really matter right now, but most of us do our development on -current, > so if we make big changes it will make it harder for us to test. Just > FYI.
Thanks for the heads up, I'll move to -current. > > I think the port looks pretty good. I edited the Makefile a little. Most > of it was just lining things up with tabs. You did have one place where > there was a space before a tab. I got rid of it. Having everything line > up is a little fussy, but I find it makes it easier to read. Thanks, no worries, it's better to be fussy and consistent! > > The on substantive thing I changes was *_DEPENDS convention is one > dependency per line. You did keep them sorted properly, just jammed > together on one line. OK, I didn't know if that was how things should go, good to know. > > I like that you have included a proper manpage. I also appreciate that > you made sure there is an uploaded tarball for the release on github. > (I'm sure other porters do as well). This might be showing my age... However I honestly find software is useless if there isn't a manpage. > I've attached the port with my updates to Makefile. Thanks. Tim
