On 2019/04/26 00:50, Kurt Mosiejczuk wrote: > On Thu, Apr 25, 2019 at 03:54:58PM -0600, Timothy Brown wrote: > > > I would like to start the process of getting a new program into the > > ports tree. > > > The program is called mcds[0], it is a command line tool that queries > > a CardDAV[1] server for an email address (typical usage). I use it as > > a query_command[2] for mutt. > > > I am happy to be the maintainer for the port as I am original author. > > I have a upload my first pass as creating a port directory[3] and it > > seems to build a package[4] on 6.5 fine. > > It's generally good practice to make your port on -current. It doesn't > really matter right now, but most of us do our development on -current, > so if we make big changes it will make it harder for us to test. Just > FYI. > > > I look forward to hearing your thoughts and feedback! > > I think the port looks pretty good. I edited the Makefile a little. Most > of it was just lining things up with tabs. You did have one place where > there was a space before a tab. I got rid of it. Having everything line > up is a little fussy, but I find it makes it easier to read. > > The on substantive thing I changes was *_DEPENDS convention is one > dependency per line. You did keep them sorted properly, just jammed > together on one line. > > I like that you have included a proper manpage. I also appreciate that > you made sure there is an uploaded tarball for the release on github. > (I'm sure other porters do as well). > > I've compiled it on amd64 and arm64. (sparc64 is churning away for > a while). I don't have any calDAV set up, so someone else may need > to report in on that. For testing, I did paste the example URL for > demo.owncloud.org onto the command line. It didn't work and I didn't > expect it to. The error message wasn't super helpful though. > > I've attached the port with my updates to Makefile. > > With the changes I've mentioned I think it will be good. I'd love to see > a ports person who actually uses calDAV to test it though. > > --Kurt
I don't think mail/ is the right category, normally for this type of program we'd use productivity/. It also picks up gettext, so need to add devel/gettext to LIB_DEPENDS and intl to WANTLIB. (I have to say I'm not a fan of lining everything up on the same column if it means there's this much horizontal whitespace, but that's a maintainer preference .. I'll usually just line up within a block of lines, and ignore it if it's due to one of the few annoyingly long variable names we have :-)
