Has C++ libs in WANTLIB -> set COMPILER to avoid risk of conflicts on base=gcc arches

Very doubtful about PERMIT_PACKAGE_CDROM=Yes due to patents. No more than PERMIT_PACKAGE_FTP I think.

--
Sent from a phone, apologies for poor formatting.

On 13 November 2018 21:56:07 Brian Callahan <bcal...@devio.us> wrote:

Hi Andrey --

On 11/13/18 4:09 PM, Andrey Melentyev wrote:
Hello,

I'd like to contribute two new ports: libde265 and libheif.

libheif is a HEIF file format decoder and encoder, the format is
starting to get popularity since Apple is using it for iPhone camera
photos. The library offers C and C++ interfaces as well as an extremely
useful 'heif-convert' utility that allows converting HEIF files to JPEG
or PNG.

libheif itself doesn't do encoding or decoding but rather delegates to
x265 or libde265 respectively.

Github page: https://github.com/strukturag/libheif

libde265

h.265 video codec implementation

Github page: https://github.com/strukturag/libde265


Note that my interest in the ports in mostly from a heif-convert
consumer perspective - I have files in HEIF format and it's convenient
to have a possibility to convert to more common formats. There's also a
GIMP plugin which can become another port eventually.

Please find both ports attached, comments or questions are welcome! I'd
also appreciate if someone can test it on platforms other than amd64.


Attached are fixed up tarballs.
* SHARED_LIBS always starts at 0.0
* License marker is more correct as LGPLv3+
* I don't see the need for those binaries that come with libde265.
Having one named tests I don't like and some of the other segfault
immediately. They don't seem to be needed for libheif or its binaries,
so I took the heavy-handed approach to remove them.
* Removed the -Werror flags from both ports, since libheif doesn't build
with -Werror on
* Reflowed pkg/DESCR of both to read a bit better IMO.
* Tweaks to account for the above changes (like syncing PLISTs and WANTLIBs)

I was able to use the heif-* binaries in libheif to convert a jpeg into
a heic file and then back into pngs and jpegs.

And finally, do you want to be MAINTAINER of these ports since you're
the submitter?

~Brian



Reply via email to