Hello Brian, On Tue, 13 Nov 2018 16:55:43 -0500 Brian Callahan <bcal...@devio.us> wrote:
> Attached are fixed up tarballs. > * SHARED_LIBS always starts at 0.0 I've learned something today, thanks > * License marker is more correct as LGPLv3+ Don't mean to argue, but how does one tell? The COPYING file at https://github.com/strukturag/libde265/blob/master/COPYING contains a specific version. > * I don't see the need for those binaries that come with libde265. > Having one named tests I don't like and some of the other segfault > immediately. They don't seem to be needed for libheif or its > binaries, so I took the heavy-handed approach to remove them. Good catch. I remember looking at these binaries but then failed to act. > * Removed the -Werror flags from both ports, since libheif doesn't > build with -Werror on Did you mean to mention a certain architecture or a compiler where it fails to build with -Werror? > * Reflowed pkg/DESCR of both to read a bit better IMO. > * Tweaks to account for the above changes (like syncing PLISTs and > WANTLIBs) Thanks! > I was able to use the heif-* binaries in libheif to convert a jpeg > into a heic file and then back into pngs and jpegs. And thanks for testing it too. > And finally, do you want to be MAINTAINER of these ports since you're > the submitter? I don't have any prior experience maintaining ports but I can definitely give it a try. -- Andrey
