Forgot to attach the tarball... classic... 2018-09-07 15:01 GMT-03:00 Elias M. Mariani <marianiel...@gmail.com>: > Comments from landry@ and kn@: > - Scaffolding NO_TEST = Yes as recommended, only setting NO_TEST = No > in the ones with tests. > - Using "LXQt" instead of "lxqt" in COMMENT consistently. > > Changes here: > https://github.com/jasperla/openbsd-wip/commit/c822e97c7555002571219495b7179ebcf81c7418 > https://github.com/jasperla/openbsd-wip/commit/3e93fbf3e3c2541b300a5d3a0fc28b150e4f9116 > > ' - NAME lines are missing a space before "="' - Fixed: > https://github.com/jasperla/openbsd-wip/commit/2411e0a01ee67cd03f02a20651d065e070e28732 > > I prefer to leave the rest of the scaffolding as it is. > > This makes: > OK rsadowski@ > OK landry@ ? > > Cheers. > Elias. > > 2018-09-06 17:43 GMT-03:00 Landry Breuil <lan...@openbsd.org>: >> On Tue, Sep 04, 2018 at 11:08:36AM -0300, Elias M. Mariani wrote: >>> Tweak to switch ${FULLPKGNAME} to ${PKGSTEM} >> >> I hade a quick look at the port and it looks good, i'll have only minor >> comments: >> >> - why not moving common things like CONFIGURE_ARGS += >> -DPULL_TRANSLATIONS:BOOL=OFF and NO_TEST = Yes to Makefile.inc using >> conditionals ? Like NO_TEST ?= Yes in Makefile.inc and NO_TEST = No in >> the only ports that have tests.. it's a suggestion to remove >> redundancy, maybe it's better, or not. Your call as maintainer :) >> - almost all ports have a BDEP on build-tools, maybe move it to >> Makefile.inc too ? DISTNAME=${NAME}-${VERSION} could be moved there >> too.. but iirc there are some variables that cant be set in >> Makefile.inc, that's why in the end i did xfce4.port.mk... >> - I find it confusing to have the licence comment in Makefile.inc, but >> maybe that's only me... >> - Can you use a consistent casing for lxqt/LxQt in COMMENT ? >> - some stuff in the portstree might now pickup hidden dependencies on >> lxqt libs or binaries because configure stuff checks for it. You'll >> have to be on the lookout for those :) >> >> If there are other bits to tweaks, imo this should be done in-tree, so >> that more ppl look at it. It builds here and packages fine, and the >> Makefiles & PLISTs read okay, so ok to import x11/lxqt and meta/lxqt (as >> what's now in -wip). >> >> Landry >>
lxqt.tar.gz
Description: GNU Zip compressed data
