On Tue, Sep 04, 2018 at 11:08:36AM -0300, Elias M. Mariani wrote:
> Tweak to switch ${FULLPKGNAME} to ${PKGSTEM}
I hade a quick look at the port and it looks good, i'll have only minor
comments:
- why not moving common things like CONFIGURE_ARGS +=
-DPULL_TRANSLATIONS:BOOL=OFF and NO_TEST = Yes to Makefile.inc using
conditionals ? Like NO_TEST ?= Yes in Makefile.inc and NO_TEST = No in
the only ports that have tests.. it's a suggestion to remove
redundancy, maybe it's better, or not. Your call as maintainer :)
- almost all ports have a BDEP on build-tools, maybe move it to
Makefile.inc too ? DISTNAME=${NAME}-${VERSION} could be moved there
too.. but iirc there are some variables that cant be set in
Makefile.inc, that's why in the end i did xfce4.port.mk...
- I find it confusing to have the licence comment in Makefile.inc, but
maybe that's only me...
- Can you use a consistent casing for lxqt/LxQt in COMMENT ?
- some stuff in the portstree might now pickup hidden dependencies on
lxqt libs or binaries because configure stuff checks for it. You'll
have to be on the lookout for those :)
If there are other bits to tweaks, imo this should be done in-tree, so
that more ppl look at it. It builds here and packages fine, and the
Makefiles & PLISTs read okay, so ok to import x11/lxqt and meta/lxqt (as
what's now in -wip).
Landry
