On 2018/08/25 14:59, Rafael Sadowski wrote:
> Please find below a new diff with the following changes:
>
> - fix fetch URL (changed upstream)
> - rename DISTFILE
> - adjust TEST_DEPENDS
>
> ok?
>
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/math/graphviz/Makefile,v
> retrieving revision 1.72
> diff -u -p -u -p -r1.72 Makefile
> --- Makefile 14 Nov 2017 20:10:11 -0000 1.72
> +++ Makefile 25 Aug 2018 12:45:56 -0000
> @@ -2,9 +2,9 @@
>
> COMMENT-main= graph drawing software
>
> -DISTNAME= graphviz-2.36.0
> -REVISION= 11
> -PKGNAME-main= ${DISTNAME}
> +V= 2.40.1
> +DISTNAME = graphviz
> +PKGNAME-main= ${DISTNAME}-${V}
...
> -MASTER_SITES= ${HOMEPAGE}pub/graphviz/ARCHIVE/
> +MASTER_SITES= https://www.graphviz.org/
...
> +DISTFILES= ${V}-{pub/graphviz/stable/SOURCES/}${DISTNAME}${EXTRACT_SUFX}
DISTNAME should include the version as well, not just the name. (Otherwise the
work
directory name is unversioned which can cause problems for some things).
The renamed distfile is done the wrong way round (2.40.1-graphviz not
graphviz-2.40.1)
and in normal cases the path should still be in MASTER_SITES, i.e.:
V= 2.40.0
DISTNAME= graphviz-$V
PKGNAME-main= ${DISTNAME}
DISTFILES= graphviz-$V{graphviz}${EXTRACT_SUFX}
MASTER_SITES= https://www.graphviz.org/pub/graphviz/stable/SOURCES/
But even with that fixed it is still very fragile because it will break when
upstream update things.
So I would ask upstream if they provide stable versioned tarballs for OS
packagers
to use, and if not then mirror it ...
