I should have mentioned that I was using the version in openbsd-wip, which is the same but with the fetch fixed.
Cheers On 24 August 2018 17:09:34 BST, Stuart Henderson <s...@spacehopper.org> wrote: >On 2018/08/24 16:25, Edd Barrett wrote: >> Hi, >> >> Sorry for the delay. This seems to work, but I have comments: >> >> On Mon, Jul 30, 2018 at 06:45:53AM +0200, Rafael Sadowski wrote: >> > +DISTNAME= graphviz >> >> Yeah, I think that's going to cause chaos later. If the next >release's >> tarball has the same name we will certainly have problems. > >It doesn't even fetch. > >> I think we should upload the distfile under a sane name with a >version >> number. > >yep. > >> > -SHARED_LIBS += gvplugin_core 1.0 # 6.0 >> > -SHARED_LIBS += gvplugin_gd 1.0 # 6.0 >> > ... >> > +SHARED_LIBS += gvplugin_core 2.0 # 6.0 >> > +SHARED_LIBS += gvplugin_gd 2.0 # 6.0 >> >> How comes the major bump if the upstream major version is the same? > >Usually we look at abi changes ourselves for that rather than believing >upstream. But in this case I imagine they're actually dlopen()'d >plugins >so I'm not sure it makes sense for them to be versioned at all.. -- Sent from my Android device with K-9 Mail. Please excuse my brevity.
