On 5/4/2018 4:24 PM, Daniel Jakots wrote: > On Fri, 4 May 2018 13:35:27 +0100, David CARLIER <devne...@gmail.com> > wrote: > >> fair enough. here an updated version. > A couple of nits: > - patches/patch-CMakeLists_txt: maybe a short summary about what it's > patching would be nice > - in the README: the sh file is a zip? also please fix the useless doas > - it would be nice to ask upstream to upload a proper release on their > github repo
The sh file is a shell script, which just so happens also has the ability to be unzipped to extract the data. It cannot successfully be run as a shell script (on OpenBSD at least), so unzipping is the only option. ~Brian > - Makefile: tab vs space issue in PKGNAME, GH_*, and MAINTAINER lines > - I'd say to move NO_TEST at the end but ymmv >
