On Fri, Apr 27 2018, Jeremie Courreges-Anglas <j...@wxcvbn.org> wrote:
> On Fri, Apr 27 2018, Solene Rapenne <sol...@perso.pw> wrote:
>
> [...]
>
>> Index: files/Quirks.pm
>> ===================================================================
>> RCS file: /cvs/ports/devel/quirks/files/Quirks.pm,v
>> retrieving revision 1.605
>> diff -u -p -r1.605 Quirks.pm
>> --- files/Quirks.pm  26 Apr 2018 20:30:23 -0000      1.605
>> +++ files/Quirks.pm  27 Apr 2018 17:49:13 -0000
>> @@ -1286,6 +1286,16 @@ my $obsolete_reason = {
>>      'gtkglextmm' => 3,
>>      'goocanvas' => 3,
>>      'osm2go' => 6,
>> +    'wmbgrabimage' => 0,
>> +    'wmphoto' => 0,
>> +    'wmminichess' => 0,
>> +    'wmifinfo' => 0,
>> +    'wmwave' => 0,
>> +    'wmcb' => 0,
>> +    'wmpinboard' => 0,
>> +    'wmbiff' => 0,
>> +    'wmmail' => 0,
>> +    'wmtimer' => 0
>
> The standard practice is to also add a trailing newline

s/newline/comma/, sigh

> to the last line
> in the hash, to avoid needless noise in cvs diff output.
>
> Except for this nit, ok jca@
>
>>  };
>>  
>>  # reasons for obsolete packages
>>

-- 
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF  DDCC 0DFA 74AE 1524 E7EE

Reply via email to