On Wed, Apr 4, 2018 at 1:35 PM, Jeremie Courreges-Anglas <j...@wxcvbn.org>
wrote:
> On Wed, Apr 04 2018, Ljuba Nedeljkovic <ljuba....@gmail.com> wrote:
>> Ping.
>>
>> On Wed, Mar 14, 2018 at 5:13 PM, Klemens Nanni <k...@openbsd.org> wrote:
>>> On Wed, Mar 14, 2018 at 02:37:22AM +0100, Ljuba Nedeljkovic wrote:
>>>> Please find attached updated port's tarball with suggested fixes. One
>>>> deviation from kn's tarball is removal of `patches/patch-nlay` file and
>>>> doing shebang fix using LOCALBASE with `post-extract` target. Said
>>>> patch leaves literal `#!${LOCALBASE}/bin/bash` in installed `nlay`
>>>> script and breaks it.
>>> Not a fan of modyfing WRKSRC "manually", we have patches and SUBST_CMD
>>> for that. You'd simply patch LOCALBASE into the shebang and later do
>>>
>>> pre-configure:
>>> ${SUBST_CMD} ${WRKSRC}/nlay
>>>
>>> I'm happy to import your latest tarball with that, OK anyone?
>
> Looks good to me, however I'd like us to stop importing ports using
> GH_*. Upstream already uses publishes release assets:
>
> https://github.com/jarun/nnn/releases
>
> Could someone get in touch with them and ask them to publish proper
> source tarballs?
I did ask them to release the source code as a proper tarball three weeks ago
and it does not seem likely to happen before the next release (1.8) which brings
fixes regarding dependencies and portability issues. I will reiterate
the request
but would not count on proper release tarball for current version.
best
>
> --
> jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
--
If you wish to live wisely,
ignore sayings -- including this one.
