On Thu, Jan 25, 2018 at 11:18:12AM +0000, Stuart Henderson wrote: > On 2018/01/25 04:07, Klemens Nanni wrote: > > On Wed, Jan 24, 2018 at 10:10:55PM +0100, Rafael Sadowski wrote: > > > On Tue Jan 23, 2018 at 12:43:36AM +0100, Klemens Nanni wrote: > > > > + > > > > # libarchive (bsdtar) used as an alternative to atool; see scope.sh > > > > patch > > > > RUN_DEPENDS = archivers/libarchive \ > > > > - textproc/py-chardet > > > > + devel/desktop-file-utils \ > > > > > > [...] > > > > > > > +@exec %D/bin/update-desktop-database > > > > +@unexec-delete %D/bin/update-desktop-database > > > > > > > > > > Please don't pull that in for a console file manager. > > Those came in for completeness (portcheck also complains without them) > > but I can see why one would rather ignore it. > > I wonder if we should come up with a better policy for console apps with > desktop files, as obviously it's useful to update the database if you > *do* have a desktop environment. > > Any thoughts on using "@exec %D/bin/update-desktop-database || true" (etc) > and not listing the desktop-file-utils dep *only* for console apps? > > What do you think Antoine?
Not a fan honestly. I'd rather keep things simple and just remove the desktop files in such case. That said if we could find a "clever" solution, I'd be all for it. But I don't like having to handle exceptions. -- Antoine
