Follow up: The music of witchblast is licensed under CC BY-NC-SA. I grepped through ports and found games/dangerdeep and books/progit that also are CC BY-NC-SA.
Based on that I set: PERMIT_PACKAGE_CDROM = Non-commercial PERMIT_PACKAGE_FTP = Yes Otherwise bump - it's a neat game with good music, worth a try. -------------------------------------------- On Fri, 11/24/17, Thomas Frohwein <[email protected]> wrote: Subject: Re: New port: witchblast (roguelite dungeon crawler) To: "Ports Mailing List" <[email protected]>, "Stuart Henderson" <[email protected]> Date: Friday, November 24, 2017, 10:50 AM Thanks for your feedback, Stuart. > - sfml should be LIB_DEPENDS not BUILD_DEPENDS Done > , then you can add some missing WANTLIB as shown by port-lib-depends-check port-lib-depends-check confused me at first with adding ".1" to those libraries. found a precedent in games/mars and games/extremetuxracer like this: WANTLIB += sfml-audio sfml-graphics sfml-system sfml-window which fixes the issue. > - no need to list ninja in BUILD_DEPENDS, or SEPARATE_BUILD, the cmake module takes care of this Done. > - the HOMEPAGE you've used is set by default for a port using GH_*, we usually skip setting this explicitly Done. > - as pointed out by portcheck, remove the X bits from the port files. (and the extra copy of portcheck; I add /usr/ports/infrastructure/bin to my path) Done. > PS I'd probably choose lower-case for the wrapper script filename. Done. Also changed the folder in /usr/local/share/ to lower case for consistency Updated, builds and runs. Updated checks: thfr@dt:/usr/ports/mystuff/games/witchblast:64$ make port-lib-depends-check thfr@dt:/usr/ports/mystuff/games/witchblast:65$ thfr@dt:/usr/ports/mystuff/games/witchblast:70$ portcheck games/witchblast thfr@dt:/usr/ports/mystuff/games/witchblast:71$ thfr@dt:/usr/ports/mystuff/games/witchblast:101$ make plist ===> Updating plist for witchblast-0.7.5 Subpackage -: Stripping dirs from multimedia/sfml Subpackage -: Stripping dirs from audio/openal Subpackage -: Stripping dirs from graphics/jpeg Subpackage -: Stripping dirs from audio/libvorbis Subpackage -: Stripping dirs from audio/libogg Subpackage -: Stripping dirs from audio/flac Subpackage -: Stripping dirs from converters/libiconv Scanning destdir Getting old lists 1st pass identifying files Attaching annotations Sorting out destdir files pkg/PLIST is new thfr@dt:/usr/ports/mystuff/games/witchblast:102$ I guess this means openal, jpeg, libvorbis, libogg, flac, and iconv are also WANTLIB..?? Haven't added them. Attached the updated tgz
witchblast.tgz
Description: Binary data
