Good work for a first port. A few things:
- sfml should be LIB_DEPENDS not BUILD_DEPENDS, then you can add some
missing WANTLIB as shown by port-lib-depends-check
- no need to list ninja in BUILD_DEPENDS, or SEPARATE_BUILD, the cmake
module takes care of this
- the HOMEPAGE you've used is set by default for a port using GH_*, we
usually skip setting this explicitly
- as pointed out by portcheck, remove the X bits from the port files. (and
the extra copy of portcheck; I add /usr/ports/infrastructure/bin to my path)
--
Sent from a phone, apologies for poor formatting.
On 24 November 2017 07:25:26 Thomas Frohwein <frohw...@ymail.com> wrote:
Hi,
witchblast is a roguelite graphical dungeon crawler in the vein of Binding
of Isaac. You play as a novice magician, progressing through randomly
generated dungeons.
Homepage: https://github.com/Cirrus-Minor/witchblast
Tested and working on amd64. Sound, graphics, and keyboard controls
working. Haven't tested gamepad.
Please test and comment. This is my first port and feedback is highly
appreciated!
/usr/ports/mystuff/games/witchblast$ make port-lib-depends-check
witchblast-0.7.5(games/witchblast):
Missing lib: sfml-audio.1 (/usr/local/share/Witch_Blast/Witch_Blast) (NOT
REACHABLE)
Missing lib: sfml-graphics.1 (/usr/local/share/Witch_Blast/Witch_Blast)
(NOT REACHABLE)
Missing lib: sfml-system.1 (/usr/local/share/Witch_Blast/Witch_Blast) (NOT
REACHABLE)
Missing lib: sfml-window.1 (/usr/local/share/Witch_Blast/Witch_Blast) (NOT
REACHABLE)
*** Error 1 in target 'port-lib-depends-check' (ignored)
/usr/ports/mystuff/games/witchblast$
/usr/ports/mystuff/games/witchblast:188$ ./portcheck
executable file: Makefile
executable file: portcheck
executable file: files/Witch_Blast
extra file: portcheck
games/witchblast
/usr/ports/mystuff/games/witchblast$
A few notes on the port:
- CMakeLists.txt had no Unix install target, which I patched in
- binary is in /usr/local/share/Witch_Blast, /usr/local/bin has shell
script to launch it (followed roughly the example of corsixth port with this)
- patched save/config/hiscores location to ~/.local/share/witchblast
Best,
Thomas Frohwein
