On 8/3/2017 4:04 AM, Antoine Jacoutot wrote: > On August 2, 2017 11:16:43 PM GMT+02:00, Brian Callahan > <bcal...@devio.us> wrote: > > Hi ports -- > > I did some digging into sdl-mixer and sdl2-mixer. It turns out that for > the vast majority of users, MIDI output for these packages has never > worked. Both sdl-mixer and sdl2-mixer contain their own internal > timidity. What sdl-mixer and sdl2-mixer do is look for an > /etc/timidity.cfg to point it to a GUS patchset so that it can play MIDI > music. Currently, this is only available through the audio/timidity > port. Which means that until this morning, it was only ever available to > users who compiled timidity themselves. > > sdl-mixer and sdl2-mixer do not use the timidity binary that you get > from the audio/timidity port. > > Now that we have a freely redistributable GUS patchset, I propose we do > the following: > > Split the audio/timidity port into two ports: audio/timidity and > audio/timgm6mb-gus. audio/timidity will only provide the timidity binary > and timidity.cfg manual page. audio/timgm6mb-gus will provide the GUS > patchset and a /etc/timidity.cfg that will work with all 3: > audio/timidity, devel/sdl-mixer, and devel/sdl2-mixer. > > Add an RDEP on audio/timgm6mb-gus for all 3. Unlike fluidsynth, the 3 > timidities are useless without a patchset. > > If you're asking "why not just add an RDEP on audio/timidity where it > makes sense," the reason is audio/timidity has three FLAVORs, all of > which conflict with one another. So if a user installs for example > audio/timidity,gtk2 and we add RDEPs on audio/timidity in places, then > things will hit conflicts. And that seems to be a step backwards. > Additionally, I think the more 1997 code we can keep off peoples' > computers, the better. And if we decide to remove timidity from the > ports tree one day, it won't cause the MIDI playback of sdl-mixer and > sdl2-mixer to suddenly stop working. > > Attached is a new port, audio/timgm6mb-gus, which contains the patchset > and the /etc/timidity.cfg. A diff is also attached that makes > audio/timidity, devel/sdl-mixer, and devel/sdl2-mixer work with this new > port. With this configuration, prboom (which uses sdl-mixer) and > CorsixTH (which uses sdl2-mixer) are able to play their game music > without timidity installed. And then if you want the standalone timidity > binary, that will just work too, regardless of whether or not sdl-mixer > and sdl2-mixer are installed. > > I will then sweep the tree and figure out what things actually really > use the timidity binary, if anything. > > OK? > > ~Brian > > > If you don't RDEP on a specific FLAVOR, then any FLAVOR will match the > dependency.
Ah, right. Still, how many copies of timidity does a person need? The idea of having up to 3 different timidity programs on your computer seems like overkill to me.