On Tue, Jun 20, 2017 at 06:04:16PM +0200, Jeremie Courreges-Anglas wrote:

> >> Updated tarball attached adding a pre-configure target to disable those
> >> calls.
> 
> Some tweaks I would appreciate:
> - post-extract seems more appropriate than pre-configure
> - the issue is not a segfault, but an exception; let's mention it, as it
>   has already been a problem with other ports
> 
>   http://marc.info/?l=openbsd-ports&s=locale::facet::
> 
>   eg++/libestdc++ and clang/libc++ are affected too

Indeed, that makes sense, makes it easier to find ports with
the same issue.

> - (doesn't matter much) I find sed '//d' more idiomatic here, ymmv

It's also shorter, so yes, definitely an improvement.

> That would give:
> 
> post-extract:
>       # locale::facet::_S_create_c_locale throws in non-C locales
>       sed -i '/locale(""));/d' ${WRKSRC}/src/*.cc

New tarball attached with those modifications in.

Attachment: tudu.tar.gz
Description: application/tar-gz

Reply via email to