Frederic Cambus <f...@statdns.com> writes:
> On Mon, Jun 19, 2017 at 05:35:33PM +0200, Frederic Cambus wrote:
>
>> > $ tudu
>> > terminate called after throwing an instance of 'std::runtime_error'
>> > what(): locale::facet::_S_create_c_locale name not valid
>> > Abort trap (core dumped)
>>
>> Indeed, good catch. I was able to reproduce the issue, this is caused
>> by the locale("") calls.
>>
>> Updated tarball attached adding a pre-configure target to disable those
>> calls.
Some tweaks I would appreciate:
- post-extract seems more appropriate than pre-configure
- the issue is not a segfault, but an exception; let's mention it, as it
has already been a problem with other ports
http://marc.info/?l=openbsd-ports&s=locale::facet::
eg++/libestdc++ and clang/libc++ are affected too
- (doesn't matter much) I find sed '//d' more idiomatic here, ymmv
That would give:
post-extract:
# locale::facet::_S_create_c_locale throws in non-C locales
sed -i '/locale(""));/d' ${WRKSRC}/src/*.cc
> And the actual tarball attached, sorry.
Looks fine to me.
--
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
