Hello Stuart,
many thanks for this, the Makefile now no longer resembles an
incremental science project :)
On 12 Jan 2017, at 23:23, Stuart Henderson wrote:
I've committed the reservation in user.list; updated port attached,
Thank you for that, I imagine this prevents some race conditions.
comments on my changes:
|V= 1.1.0
|DISTNAME= dnsdist-${V}
|EXTRACT_SUFX = .tar.bz2
|PKGNAME= dnsdist-${V}
PKGNAME defaults to DISTNAME already, V is used nowhere else, so just
set DISTNAME=dnsdist-1.1.0.
Right. This is where I admit I did not use Makefile.template (managed to
skim over that bit in the Porting Guide every time) and instead stole
net/powerdns/Makefile, which unlike dnsdist has plenty reason to have
this V.
|# GPLv2
More specific version; in this case there's no "or later" so the
marker to use it "GPLv2 only"
Indeed.
|CONFIGURE_STYLE= gnu
hardcodes -O3, I've patched configure.ac to remove this and switched
to
running autoconf (CONFIGURE_STYLE=autoconf) to regenerate
Understood, and while I can think of some reasons myself, is ‘no
-O3’ some OpenBSD policy that I missed?
| lang/lua
because MODLUA_VERSION wasn't set it defaults to 5.1; dnsdist build
is picking up 5.3 preferentially if multiple versions are installed,
so I've set this explicitly.
Great.
|LIBTOOL_FLAGS= --tag=disable-static
|CONFIGURE_ARGS+= --disable-shared \
removed these, they're doing nothing here
Alright.
|SEPARATE_BUILD= No
removed, this is the default
I just grepped the rest of the ports and saw a lot of this, relying on
defaults is better of course.
|NO_TEST= Yes
removed, this is normally only used if things error out, and left
out if there are no tests, or if they're not built by default. (though
is there any disadvantage to adding --enable-unit-tests to enable
them?)
There are no ‘make check’-exposed tests in dnsdist so this would not
make a difference.
others:
- reordered variables more in line with Makefile.template
Thank you for that.
- it wasn't building for me, needed gmake, so I've added USE_GMAKE=Yes
Yes, I recall being surprised at it building without such a hint at one
time but then I forgot. Wonder why it did build for me anyway, but at
least there is no confusion now.
- picks up and links with protobuf if available at configure time;
I've added it as LIB_DEPENDS and regen'd WANTLIB
Yes, should have been explicit about that, thank you.
I see you reformatted pkg/DESCR to fit in 72 chars instead of 80; is
this something that should be updated in
http://www.openbsd.org/faq/ports/guide.html (search for fmt -w)?
I’ve tested your rework of the port and it should be no surprise to
you that it works perfectly. Is there anything I can do to move this
along into the tree?
Thanks again for your help here, sthen@.
Kind regards,
--
Peter van Dijk
PowerDNS.COM BV - https://www.powerdns.com/
