On 2017/01/12 21:08, Peter van Dijk wrote:
> Hello,
> 
> On 12 Jan 2017, at 20:37, Stuart Henderson wrote:
> 
> > On 2017/01/12 19:35, Peter van Dijk wrote:
> > > As a followup, here is my initial stab at trying to create a dnsdist
> > > port:
> > > https://github.com/openbsd/ports/compare/master...PowerDNS:dnsdist?expand=1
> > 
> > Please send a tar.gz as an attachment.
> 
> Attached.
> 
> In addition to this tar.gz, I added the following line to
> infrastructure/db/user.list:
> 
> 787 _dnsdist           _dnsdist        net/dnsdist

I've committed the reservation in user.list; updated port attached,
comments on my changes:

|V=                     1.1.0
|DISTNAME=              dnsdist-${V}
|EXTRACT_SUFX =         .tar.bz2
|PKGNAME=               dnsdist-${V}

PKGNAME defaults to DISTNAME already, V is used nowhere else, so just
set DISTNAME=dnsdist-1.1.0.

|# GPLv2

More specific version; in this case there's no "or later" so the
marker to use it "GPLv2 only"

|CONFIGURE_STYLE=       gnu

hardcodes -O3, I've patched configure.ac to remove this and switched to
running autoconf (CONFIGURE_STYLE=autoconf) to regenerate

|               lang/lua

because MODLUA_VERSION wasn't set it defaults to 5.1; dnsdist build
is picking up 5.3 preferentially if multiple versions are installed,
so I've set this explicitly.

|LIBTOOL_FLAGS=         --tag=disable-static
|CONFIGURE_ARGS+=       --disable-shared \

removed these, they're doing nothing here

|SEPARATE_BUILD=                No

removed, this is the default

|NO_TEST=               Yes

removed, this is normally only used if things error out, and left
out if there are no tests, or if they're not built by default. (though
is there any disadvantage to adding --enable-unit-tests to enable them?)

others:

- reordered variables more in line with Makefile.template
- it wasn't building for me, needed gmake, so I've added USE_GMAKE=Yes
- picks up and links with protobuf if available at configure time;
I've added it as LIB_DEPENDS and regen'd WANTLIB

Attachment: dnsdist.tgz
Description: application/tar-gz

Reply via email to