On Fri, Dec 02, 2016 at 03:03:07PM +0100, Jeremie Courreges-Anglas wrote: > Jeremie Courreges-Anglas <[email protected]> writes: > > > Sol??ne Rapenne <[email protected]> writes: > > > >> Le 2016-12-01 16:38, Sol??ne Rapenne a ??crit??: > >>> Le 2016-11-30 21:28, Jeremie Courreges-Anglas a ??crit??: > >>>> > >>>> Note that the build is silent which is bad. Adding verbose=1 to > >>>> MAKE_FLAGS would have helped to spot an -Os cc flag that shouldn't be > >>>> there. The link step shouldn't use -s since it makes DEBUG=-g > >>>> useless. > >>>> > >>>> This seems to embed lua-5.1, using lua from ports could be nice - if > >>>> possible of course. > >>>> > >>>> Back to the purpose of the port, it would be nice to check whether the > >>>> generated Makefiles would be usable within the OpenBSD ports tree. > >>>> But > >>>> are you just looking for feedback or are you actually submitting it > >>>> for > >>>> inclusion? > >>> > >>> New version here > >>> > >>> I would like to submit it for inclusion in the ports tree because it's > >>> a > >>> dependency of another submission of mine (games/t-engine) > >> > >> New version : > >> > >> - removing -Os compilation flag > >> - DOC link changed in DESCR > >> - licence in Makefile > > > > Updated tarball that: > > - renames the port directory to premake4 > > - fixes the offending tests: use ldconfig -r to find libraries available > > on the system. > > > > Patching a lua source file is a bit of a pain here since we have to > > regenerate the C files that embed the lua source, hence the XXX comment. > > I think that this is good for an import, it is needed for Solene's > t-engine/tome port. Could I please get reviews? >
WANTLIB is missing 'm' - with that change OK awolk@ to import tested against a local download of t-engine. Regards Adam
