Solène Rapenne <sol...@perso.pw> writes: > Hello,
Hi, > I would like feedback about my port, it's a tool which generate > makefile. > > It's only one binary once compiled. Comments below, > # $OpenBSD$ > > COMMENT= Premake is a build configuration tool "build configuration tool" would be enough I think. See what item 17 in http://www.openbsd.org/faq/ports/guide.html says about COMMENT. > V= 4.4-beta5 > NAME= premake-${V} > PKGNAME= premake-${V:C/\-.*//} > DISTNAME= ${NAME}-src DISTNAME= premake-4.4-beta5-src PKGNAME= premake-4.4beta5 is more readable IMO. "beta5" should be included in the version as per packages-specs(7). > > CATEGORIES= devel > > HOMEPAGE= https://premake.github.io > > MASTER_SITES= ${MASTER_SITE_SOURCEFORGE:=premake/} > EXTRACT_SUFX= .zip > > # 3-clause BSD I think we settled on using just "BSD" for license markers. > PERMIT_PACKAGE_CDROM= Yes > WANTLIB= c > > NO_TEST= Yes But there is a tests/ directory. > USE_GMAKE= Yes > > WRKDIST= ${WRKDIR}/${NAME} Here you could just use WRKDIST= ${WRKDIR}/${DISTNAME:S/-src$//} > WRKBUILD= ${WRKSRC}/build/gmake.unix > > do-install: > ${INSTALL_PROGRAM} ${WRKSRC}/bin/release/premake4 ${PREFIX}/bin/premake It's a shame that there isn't any documentation in the tarball... that's not something you can fix of course, but adding a link to https://github.com/premake/premake-core/wiki in DESCR could be helpful. BTW the content of DESCR is dubious, IMO. https://github.com/premake/premake-core/wiki/What-Is-Premake has a more neutral and informative description: "Premake is a command line utility which reads a scripted definition of a software project and, most commonly, uses it to generate project files for toolsets like Visual Studio, Xcode, or GNU Make." > .include <bsd.port.mk> Note that the build is silent which is bad. Adding verbose=1 to MAKE_FLAGS would have helped to spot an -Os cc flag that shouldn't be there. The link step shouldn't use -s since it makes DEBUG=-g useless. This seems to embed lua-5.1, using lua from ports could be nice - if possible of course. Back to the purpose of the port, it would be nice to check whether the generated Makefiles would be usable within the OpenBSD ports tree. But are you just looking for feedback or are you actually submitting it for inclusion? -- jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
