Stuart Henderson <s...@spacehopper.org> writes:

> On 2016/11/06 18:19, Jeremie Courreges-Anglas wrote:
>> - it feels weird not to use MODPY_PI just because MODPY_EGG_VERSION
>>   doesn't match the end of DISTNAME.  I can't see an easy workaround.
>>   *shrug*
>
> There's a possible workaround but it feels pretty dirty
>
> V =                   0.4.19
> MODPY_EGG_VERSION =   0.04.19
> DISTNAME =            Unidecode-0.04.19
> PKGNAME =             py-${DISTNAME:L}
>
> SUBST_VARS +=         V
> MODPY_PI =            Yes
>
> It's not the end of the world to use MASTER_SITES = ${MASTER_SITE_PYPI..}
> but I'd add a comment to stop someone else having to try and figure out
> why it's not using MODPY_PI.

Done.

# MODPY_PI doesn't work because DISTNAME version number is different
# from MODPY_EGG_VERSION, as we want the latter to be substituted in
# the PLIST
MASTER_SITES =          ${MASTER_SITE_PYPI:=U/Unidecode/}

> Strongly prefer this to a GH_ checkout.

Yup. Committed.

-- 
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF  DDCC 0DFA 74AE 1524 E7EE

Reply via email to