Daniel Jakots <danj+o...@chown.me> writes:
> On Sun, 06 Nov 2016 18:19:27 +0100, Jeremie Courreges-Anglas
> <j...@wxcvbn.org> wrote:
>
> I was also looking at this :)
>
>> > any ideas?
>>
>> The locale is not set in the test environment.
>>
>> > in any case i dont think that's a real showstopper.
>> > please test and commit.
>>
>> Updated diff:
>> - MASTER_SITES moved below PERMIT_*, as in Makefile.template
>> - no need to specify the default test target
>> - no need for FLAVOR tests in post-install
>>
>> Points that bug me:
>> - the diff below adds LC_CTYPE to MAKE_ENV. It feels like it should
>> be in TEST_ENV, but the latter is not honored by python.port.mk
>
> I put it in the test target.
>
>> - it feels weird not to use MODPY_PI just because MODPY_EGG_VERSION
>> doesn't match the end of DISTNAME. I can't see an easy workaround.
>> *shrug*
>
> One possibility is to move to github.
It's not like it's a big issue. I tend to prefer proper releases rather
than picking a tag on github. (Their contents may not be the same.)
>> Thoughts? Shall we go with the diff below?
>
> Here's my diff which I updated with your remarks.
[...]
> do-test:
> - @${MODPY_TEST_TARGET}
> + cd ${WRKSRC} && LC_ALL=C.UTF-8 ${MODPY_BIN} setup.py test
That would obviously work, but I'd prefer leaving MAKE_ENV (possibly
commented-out) with a note rather than yet another handrolled do-test
target.
See http://marc.info/?l=openbsd-ports&m=147847129504189&w=2 for
a possible solution.
--
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
