On Fri, Aug 26, 2016 at 10:39 AM, David Coppa <dco...@gmail.com> wrote: > On Fri, Aug 26, 2016 at 10:26 AM, Anthony J. Bentley <anth...@anjbe.name> > wrote: > >> To save Ryan from having to send yet another revision, attached are the >> ports with a few final changes: >> >> - update urbanterror license marker to GPLv2+ >> - update urbanterror-data license: PERMIT_PACKAGE_FTP=Yes >> - re-add RUN_DEPENDS on data and remove pkg/README in urbanterror >> >> ok to import? >> >> -- >> Anthony J. Bentley > > Two minor nits: > > "${V}" is not used elsewhere, so just set DISTNAME to > "urbanterror-4.2.023pl1".
And remove "V". > "DEFAULT_BASEDIR=${LOCALBASE}/share/urbanterror" should be > "DEFAULT_BASEDIR=${TRUEPREFIX}/share/urbanterror". Also, COMMENT should be lowercase: "Fast-paced" -> "fast-paced"