On 2016/05/05 11:29, Dmitrij D. Czarkoff wrote: > Antoine Jacoutot said: > > I am OK with this but why don't you use INSTALL_PROGRAM in the > > MODGO_INSTALL_TARGET then, instead of cp? > > I'd give us more control about the owner/mode no? > > The patch below adds this change. But pkg_create already resets > owner/mode anyway, so I am not sure it is really needed.
pkg_create checks but doesn't reset. (I run into package failures all over the place when I'm on a machine with umask 077 and try to build a package without remembering to loosen it...) > FWIW I planned to switch MODGO_INSTALL_TARGET for libraries to > INSTALL_DATA, but I don't think this should be done in this commit. > > -- > Dmitrij D. Czarkoff > > Index: lang/go/Makefile <snip> ok
