"Dmitrij D. Czarkoff" <czark...@gmail.com> writes: > Dmitrij D. Czarkoff said: >> Stuart Henderson said: >> > On 2016/04/21 19:35, Christian Weisgerber wrote: >> >> Dmitrij D. Czarkoff: >> >> >> >>>> I think you should just set >> >>>> INSTALL_STRIP = >> >>>> in the ports (or modules) that require it and be done with it. >> >>>> No point in introducing yet another variable. >> >>> >> >>> INSTALL_STRIP is mentioned in mk.conf(5), so it is a user setting. >> >>> /etc/mk.conf may contain INSTALL_STRIP=-s, and that would override >> >>> INSTALL_STRIP= from port. >> >> >> >> In practice, INSTALL_STRIP has two possible values: "-s" and "". >> >> "-s" is already the default, so the only user setting that makes >> >> any sense is "". Having some ports already set it to "" is just >> >> fine. >> >> >> >> A few ports already do this. >> > >> > Makes sense to me. go-bootstrap needs it too. >> >> Well, then asking for OKs for the following patch. > > While at it, maybe we should move description of INSTALL_STRIP from > mk.conf(5) to bsd.port.mk(5), as apparently it is now used this way?
I don't think so, INSTALL_STRIP comes from bsd.own.mk. -- jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
