Hi, New tarball attached.
On Tue, Apr 19, 2016 at 12:48:25AM +0200, Adam Wolk wrote:
> Some feedback.
>
> 1.
>
> $
> portcheck hardcoded paths detected in pkg/README, consider using
> SUBST_VARS and TRUEPREFIX/LOCALBASE/LOCALSTATEDIR/VARBASE net/syncthing
>
> not sure what portcheck hates here but it does. Maybe the /var paths?
Yeah, I think it's /var, for which (AFAIK) there is no variable for.
> 2.
>
> The port uses GH_* variables with are not preferred when upstream
> provides release tarballs and syncthing does. I have been dumb enough
> to try and switch the port to use a normal MASTER_SITES. I'm attaching
> a new port plus a diff so you can see the pain I went through to get it
> working. It's far more uglier than GH_* vars but not subject to tag
> sliding if upstream decides to move it.
Good. Thanks.
> 3.
>
> I added a note to README about the way I start up my syncthing
> instances using crontab. I think it's a useful trick to pass on to
> other people.
Thanks. I tweaked it a bit.
> 4.
>
> Now that I look at it, the -version ${GH_TAGNAME} should probably
> be just replaced with ${V} but I ran out of time to test this.
It needs to be v${V} or else we get:
18:07:12 FATAL: Invalid version string "0.12.22"; does not match regexp
^v\d+\.\d+\.\d+(-[a-z0-9]+)*(\+\d+-g[0-9a-f]+)?(-dirty)?$
Are we converging on something importable?
--
Best Regards
Edd Barrett
http://www.theunixzoo.co.uk
syncthing_3.tgz
Description: application/tar-gz
