On Mon, 18 Apr 2016 22:01:24 +0100 Edd Barrett <e...@theunixzoo.co.uk> wrote:
> Hi,
>
> pkg/DESCR:
> ---8<---
> Syncthing is an application that lets you synchronize your files
> across multiple devices. This means the creation, modification or
> deletion of files on one machine will automatically be replicated to
> your other devices. We believe your data is your data alone and you
> deserve to choose where it is stored. Therefore Syncthing does not
> upload your data to the cloud but exchanges your data across your
> machines as soon as they are online at the same time.
> --->8---
>
> I've been using this to sync notes between my server, laptop, tablet
> and phone. Seems to work nicely.
>
> It's a go app, but all the deps come bundled.
>
> This port is mostly by czarkoff@ from openbsd-wip. All I have done is
> update to the latest version, add a README and test it. We agreed by
> mail that I would take MAINTAINER.
>
> OK?
>
Some feedback.
1.
$
portcheck hardcoded paths detected in pkg/README, consider using
SUBST_VARS and TRUEPREFIX/LOCALBASE/LOCALSTATEDIR/VARBASE net/syncthing
not sure what portcheck hates here but it does. Maybe the /var paths?
2.
The port uses GH_* variables with are not preferred when upstream
provides release tarballs and syncthing does. I have been dumb enough
to try and switch the port to use a normal MASTER_SITES. I'm attaching
a new port plus a diff so you can see the pain I went through to get it
working. It's far more uglier than GH_* vars but not subject to tag
sliding if upstream decides to move it.
3.
I added a note to README about the way I start up my syncthing
instances using crontab. I think it's a useful trick to pass on to
other people.
4.
Now that I look at it, the -version ${GH_TAGNAME} should probably
be just replaced with ${V} but I ran out of time to test this.
Regards,
Adam
diff -u syncthing-eb/Makefile syncthing/Makefile
--- syncthing-eb/Makefile Mon Apr 18 22:53:17 2016
+++ syncthing/Makefile Tue Apr 19 00:21:55 2016
@@ -1,10 +1,11 @@
# $OpenBSD$
-GH_ACCOUNT = syncthing
-GH_PROJECT = syncthing
-GH_TAGNAME = v0.12.22
COMMENT = open decentralized synchronization utility
+V = 0.12.22
+DISTNAME = syncthing-${V}
+DISTFILES = syncthing-source-v${V}${EXTRACT_SUFX}
+
CATEGORIES = net
HOMEPAGE = https://syncthing.net/
@@ -15,12 +16,17 @@
WANTLIB += c pthread
+MASTER_SITES = https://github.com/syncthing/syncthing/releases/download/v${V}/
+
+WRKSRC = ${WRKDIR}/go/src/github.com/syncthing/syncthing
+
MODULES = lang/go
MODGO_TYPE = bin
+MODGO_SUBDIR = ${WRKDIR}/syncthing
do-build:
cd ${WRKSRC} && ${MODGO_CMD} run build.go \
- -version ${GH_TAGNAME} -no-upgrade
+ -no-upgrade
do-test:
cd ${WRKSRC} && ${MODGO_CMD} run build.go test
diff -u syncthing-eb/distinfo syncthing/distinfo
--- syncthing-eb/distinfo Sat Apr 16 15:02:13 2016
+++ syncthing/distinfo Mon Apr 18 23:47:27 2016
@@ -1,2 +1,2 @@
-SHA256 (syncthing-0.12.22.tar.gz) =
EEQC/NGi0CNE4yzr2fnWJJSUgn6H3dLH0B7kMUjILSo=
-SIZE (syncthing-0.12.22.tar.gz) = 4047399
+SHA256 (syncthing-source-v0.12.22.tar.gz) =
pgsw/av5FxD0LVycLIIwhziyq20RIBTBs+IL/RLsjbg=
+SIZE (syncthing-source-v0.12.22.tar.gz) = 4816944
Common subdirectories: syncthing-eb/pkg and syncthing/pkg
syncthing-awolk.tar.gz
Description: application/gzip
