Hey,
On Sat, Sep 05, 2015 at 11:46:57AM -0700, J. Scott Heppler wrote:
> I incorporated you patch and it built on amd64. Attached is an updated
> tarball.
Thanks for this. Here's some feedback against your older tarball. Sounds like
most of this still applies though.
Your OpenBSD CVS tag should be '$OpenBSD$' to ensure it expands
correctly.
If we are planning on renaming this from tint to tint2, thus importing
x11/tint2 fresh, then we might aswell make the spaces around assignmnets
consistent. IIRC, 'VAR = val' is the preferred method.
Also, if we are renaming, the package path will change, and we should
deal with the upgrade path. See @pkgpath in pkg_create(1).
Since you are installing new icons under ${PREFIX}/share/icons, you will
need to update the gtk icon cache. Grep in-tree PLISTS for
"update-icon-cache" to see how to do that.
You should wrap your pkg/DESCR with 'fmt -72'.
You could balance your WANTLIB lines to make them look a bit nicer. I
tend to just remove them all, then run 'make port-lib-depends-check' and
paste back the WANTLIB list it emits.
> # move the example tintrc to /usr/local/share/examples/tint2
I'd just remove that, it's obvious from the lines that follow it.
> SUBST_VARS = INSTDIR
Are you sure you need that? Grepping the port and sources turns up
nothing.
Other than that looks good. Seems to run fine.
Hope that helps.
--
Best Regards
Edd Barrett
http://www.theunixzoo.co.uk
