On 2015/08/29 19:43, Ingo Feinerer wrote:
> - Do not pass CFLAGS and CPPFLAGS as the build appears to work out of the box

check to make sure that e.g. 'make DEBUG="-O0 -g"' correctly gets passed
through without these.

> - The port directory is "jags" whereas the package name is "JAGS". I do
>   not know if this might cause problems and is good practice.

all lower-case is normally preferred.

> - PFRAG.shared could probably be eliminated by moving corresponding
>   lines to PLIST. make plist however creates PFRAG.shared (whereas often
>   it is capable of this "folding in"), so I guess that is fine.

this is because of the .so "modules". if these are required for operation
of the port, add SHARED_ONLY=Yes and regen plist which will put everything
in PLIST.

the static-linked versions of modules are normally useless, just adding
to build time and package size; these can usually be avoided with
"LIBTOOL_FLAGS= --tag=disable-static".

Reply via email to