> Been a while since I checked in on math/jags to see if anyone might be
> willing to test it
> (http://marc.info/?l=openbsd-ports&m=143282435205752&w=2). Would
> definitely appreciate it if there are any scientific users of
> OpenBSD--people familiar with the fortran toolchains, etc--that could
> check this work and possibly see about adding it to the ports
> collection.

Tested on amd64 in combination with the R package rjags.

Some comments (with my changes attached to this posting):

- COMMENT: Better use "Gibbs" than "gibbs" as it is a last name
- COMMENT: I prefer the wording from the upstream homepage
- Reduced/fixed WANTLIB
- "MODULES= fortran" defines MODFORTRAN_BUILD_DEPENDS so no need to ask
  for lang/g77. Moreover, g77 is the default for MODFORTRAN_COMPILER.
  See "man port-modules" for details.
- Add comment why USE_LIBTOOL = gnu is needed (which should normally be
  avoided).
- Use YACC Makefile variable (automatically passed to GNU configure).
  See "man bsd.port.mk".
- Use SEPARATE_BUILD = Yes
- Do not pass CFLAGS and CPPFLAGS as the build appears to work out of the box
- Pass ${CONFIGURE_SHARED} to CONFIGURE_ARGS (as we have SHARED_LIBS)
- Add devel/flex build dependency and enforce its use (ac_cv_prog_LEX).
  The build fails with flex from base. Did it work for you?

Open issues:

- Would you like to take MAINTAINERship?
- The port directory is "jags" whereas the package name is "JAGS". I do
  not know if this might cause problems and is good practice.
- PFRAG.shared could probably be eliminated by moving corresponding
  lines to PLIST. make plist however creates PFRAG.shared (whereas often
  it is capable of this "folding in"), so I guess that is fine.

Best regards,
Ingo

Attachment: jags.tar.gz
Description: application/tar-gz

Reply via email to